> -----Original Message----- > From: fio-owner@xxxxxxxxxxxxxxx [mailto:fio-owner@xxxxxxxxxxxxxxx] On > Behalf Of kusumi.tomohiro@xxxxxxxxx > Sent: Monday, February 13, 2017 10:33 AM > To: axboe@xxxxxxxxx; fio@xxxxxxxxxxxxxxx > Cc: Tomohiro Kusumi <tkusumi@xxxxxxxxxx> > Subject: [PATCH 2/6] configure: Use x86 instead of i386 for $cpu for IA32 > > From: Tomohiro Kusumi <tkusumi@xxxxxxxxxx> > > fio internally uses "x86" for any sort of IA32, so use x86 for $cpu > as well which gets printed on ./configure. That's the gcc cpu_type, and derives from the __i386__ macro value that configure is checking for. All the other architectures stay with the cpu_type name at this level. > # grep i386 . -rI > ./arch/arch.h:#if defined(__i386__) > ./configure:elif check_define __i386__ ; then > ./configure: cpu="i386" > ./configure: i386|i486|i586|i686|i86pc|BePC) > ./configure: cpu="i386" > ./crc/sha1.c:#if defined(__i386__) || defined(__x86_64__) > ./crc/xxhash.c:#if defined(__ARM_FEATURE_UNALIGNED) || > defined(__i386) || defined(_M_IX86) || defined(__x86_64__) || > defined(_M_X64) That search points out crc/xxhash.c is missing the trailing __ on the __i386__ macro, which seems like a bug. The search should have also found this in arch/arch-x86.h: #define FIO_ARCH (arch_i386) and an enum arch/arch.h: enum { arch_i386, I think they would also need to be changed, if the change is made. FIO_ARCH is used by gfio in the Architecture box. --- Robert Elliott, HPE Persistent Memory -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
