Re: [PATCH] Change misleading error message for invalid size= value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/13/2016 09:27 AM, Jakub Sitnicki wrote:
> The error message refers to the IO size, yet another parameter, but we
> actually compare the size parameter value against the block size.
> 
> Change the message to reflect the code, and make it easier for the user
> to see what values are we comparing.
> 
> Signed-off-by: Jakub Sitnicki <jkbs@xxxxxxxxxx>
> ---
>  init.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/init.c b/init.c
> index 382fa1f..36feb51 100644
> --- a/init.c
> +++ b/init.c
> @@ -822,7 +822,8 @@ static int fixup_options(struct thread_data *td)
>  	 * If size is set but less than the min block size, complain
>  	 */
>  	if (o->size && o->size < td_min_bs(td)) {
> -		log_err("fio: size too small, must be larger than the IO size: %llu\n", (unsigned long long) o->size);
> +		log_err("fio: size too small, must not be less than minimum block size: %llu < %u\n",
> +			(unsigned long long) o->size, td_min_bs(td));
>  		ret = 1;
>  	}

Thanks, applied.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux