Hey Jens, I don't see where the patch is, did I missed something ? ----- Mail original ----- De: "Jens Axboe" <axboe@xxxxxxxxx> À: "Martin Dev" <mrturtledev@xxxxxxxxx>, fio@xxxxxxxxxxxxxxx Envoyé: Vendredi 5 Août 2016 15:50:53 Objet: Re: Unlink after each loop in job On 08/05/2016 01:31 AM, Martin Dev wrote: > Hey Jens, > > I applied your patch, but it doesn't unlink the file as it continues > at the !fio_file_open(f) in unlink_files(), run for 2 loops > > Clear State: 0 > Clear State: 1 > Doing unlink > Starting file loop > File is not open! > > I assume it's OK to flip it and check if the file is open then > continue (so not to unlink files that are potentially still in use) > > I'll update the readme/docs and fio.1 as suggested. The file_open() should just be removed, at best, or at least we should flip the check, it doesn't make a lot of sense to only unlink if it's open. In any case, it doesn't really matter if it's open or not, last user will drop it. So I'd just drop that check. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
