Re: what is the sample logger doing when the buffer fills up?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/22/2016 09:55 AM, Jens Axboe wrote:
Actually, I think it's missing one more thing. Try the attached v2
instead. Karl, you mentioned the iops = 0 trick. I don't think that's
the right fix, but I think you were getting close. I suspect that we
sometimes wake up a little early. Let's say we want to log the 6000
entry, but we wake up at 5999 instead. We add the regular stat sample,
and clear interval. But we don't add the averaged log entry, since the
time hasn't passed yet, we're missing 1 msec. Hence when we do wake up
1msec later, spent/iops will be zero. You're continue adds the log
entry, but misses the data.

I'm feeling good about this change, so I committed it:

http://git.kernel.dk/cgit/fio/commit/?id=d454a205f81e1b122020cb4fb469c5a0c9d3195f

So just test current -git, would love to hear if it fixes the issue for you guys.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux