On 06/01/2016 01:04 AM, Omar Sandoval wrote:
From: Omar Sandoval <osandov@xxxxxx>
The man page claims that iodepth_batch=0 falls back to whatever was
specified for iodepth, but the enforced minimum of 1 means that 0 is not
actually valid.
Fixes: a2e6f8ac56a9 ("Make iodepth_batch=1 by default")
Signed-off-by: Omar Sandoval <osandov@xxxxxx>
Probably a better idea to just adjust the check-and-set instead, ala the
below:
diff --git a/init.c b/init.c
index 7166ea766d8a..e82446ba6f2a 100644
--- a/init.c
+++ b/init.c
@@ -695,7 +695,8 @@ static int fixup_options(struct thread_data *td)
/*
* If batch number isn't set, default to the same as iodepth
*/
- if (o->iodepth_batch > o->iodepth || !o->iodepth_batch)
+ if (o->iodepth_batch > o->iodepth ||
+ !fio_option_is_set(o, iodepth_batch))
o->iodepth_batch = o->iodepth;
/*
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
