On 05/16/2016 03:50 PM, Michael Schoberg (mschoberg) wrote:
I think I found an issue in os\windows\posix.c that results in a FIO crash (on Windows.) I'm including a patch that resolves the crash for us, but includes another (optional) fix. > > Crash issue: possix.c - ctime_r() will reference a negative array index on Sunday. SYSTEMTIME states the days of the week as: "0=Sunday, .. , 6=Saturday." The "fix" can likely be dialed back to safely assume the days/months will adhere to how they're documented. Optional - StringCchPrintfA() calls should allow for the string plus a NULL character. Instead, the value getting passed in is for the entire string size.
Thanks, both look good, applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
