Success! Test1: Round io_size to match bs: PASS # ./fio/fio --name=SW_1MB_QD32 --ioengine=libaio --direct=1 --rw=write --iodepth=32 --size=1% --runtime=60s --time_based --numjobs=1 --bs=1m --overwrite=1 --filename=/dev/nvme2n1 SW_1MB_QD32: (g=0): rw=write, bs=1M-1M/1M-1M/1M-1M, ioengine=libaio, iodepth=32 fio-2.3-27-g543e Starting 1 process Jobs: 1 (f=1): [W(1)] [100.0% done] [0KB/1422MB/0KB /s] [0/1422/0 iops] [eta 00m:00s] SW_1MB_QD32: (groupid=0, jobs=1): err= 0: pid=89722: Thu Jan 14 14:39:48 2016 write: io=84664MB, bw=1410.1MB/s, iops=1410, runt= 60007msec Test2: Loop around max device size and continue IO with fixed runtime: PASS # ./fio/fio --name=SW_1MB_QD32 --ioengine=libaio --direct=1 --rw=write --iodepth=32 --size=100% --runtime=15m --time_based --numjobs=1 --bs=1m --overwrite=1 --filename=/dev/nvme2n1 SW_1MB_QD32: (g=0): rw=write, bs=1M-1M/1M-1M/1M-1M, ioengine=libaio, iodepth=32 fio-2.3-27-g543e Starting 1 process Jobs: 1 (f=1): [W(1)] [100.0% done] [0KB/1429MB/0KB /s] [0/1429/0 iops] [eta 00m:00s] SW_1MB_QD32: (groupid=0, jobs=1): err= 0: pid=89923: Thu Jan 14 14:55:41 2016 write: io=1227.2GB, bw=1397.2MB/s, iops=1397, runt=900010msec Test3: Loop around max device size and continue IO with fixed total IO, round total IO to bs: PASS # ./fio/fio --name=SW_1MB_QD32 --ioengine=libaio --direct=1 --rw=write --iodepth=32 --size=100% --io_size=810000000000 --numjobs=1 --bs=1m --overwrite=1 --filename=/dev/nvme2n1 SW_1MB_QD32: (g=0): rw=write, bs=1M-1M/1M-1M/1M-1M, ioengine=libaio, iodepth=32 fio-2.3-27-g543e Starting 1 process Jobs: 1 (f=1): [W(1)] [100.0% done] [0KB/1377MB/0KB /s] [0/1377/0 iops] [eta 00m:00s] SW_1MB_QD32: (groupid=0, jobs=1): err= 0: pid=89175: Thu Jan 14 14:24:35 2016 write: io=772477MB, bw=1399.1MB/s, iops=1399, runt=551791msec Test4: Loop around max device size and continue IO with fixed total IO, total IO is already aligned to bs: PASS # ./fio/fio --name=SW_1MB_QD32 --ioengine=libaio --direct=1 --rw=write --iodepth=32 --size=100% --io_size=810675077120 --numjobs=1 --bs=1m --overwrite=1 --filename=/dev/nvme2n1 SW_1MB_QD32: (g=0): rw=write, bs=1M-1M/1M-1M/1M-1M, ioengine=libaio, iodepth=32 fio-2.3-27-g543e Starting 1 process Jobs: 1 (f=1): [W(1)] [100.0% done] [0KB/1433MB/0KB /s] [0/1433/0 iops] [eta 00m:00s] SW_1MB_QD32: (groupid=0, jobs=1): err= 0: pid=89446: Thu Jan 14 14:36:52 2016 write: io=773120MB, bw=1398.9MB/s, iops=1398, runt=552709msec Regards, Jeff -----Original Message----- From: Jens Axboe [mailto:axboe@xxxxxxxxx] Sent: Thursday, January 14, 2016 1:47 PM To: Jeff Furlong <jeff.furlong@xxxxxxxx>; Jens Rosenboom <j.rosenboom@xxxxxxxx>; Sitsofe Wheeler <sitsofe@xxxxxxxxx> Cc: fio@xxxxxxxxxxxxxxx Subject: Re: time_based option broken On 01/14/2016 01:22 PM, Jens Axboe wrote: > On 01/14/2016 01:10 PM, Jens Axboe wrote: >> On 01/14/2016 12:51 PM, Jeff Furlong wrote: >>> Latest commit seems to help, but found one more issue: >>> >>> # blockdev --getsize64 /dev/nvme2n1 >>> 800166076416 >>> >>> 800166076416B = 763097.8MB >>> >>> Test1: Round io_size to match bs: PASS # ./fio/fio >>> --name=SW_1MB_QD32 --ioengine=libaio --direct=1 --rw=write >>> --iodepth=32 --size=1% --runtime=60s --time_based --numjobs=1 >>> --bs=1m >>> --overwrite=1 --filename=/dev/nvme2n1 >>> SW_1MB_QD32: (g=0): rw=write, bs=1M-1M/1M-1M/1M-1M, ioengine=libaio, >>> iodepth=32 >>> fio-2.3-26-g19dd >>> Starting 1 process >>> Jobs: 1 (f=1): [W(1)] [100.0% done] [0KB/1380MB/0KB /s] [0/1380/0 >>> iops] [eta 00m:00s] >>> SW_1MB_QD32: (groupid=0, jobs=1): err= 0: pid=80311: Thu Jan 14 >>> 10:11:36 2016 >>> write: io=84966MB, bw=1415.1MB/s, iops=1415, runt= 60009msec >>> >>> Test2: Loop around max device size and continue IO with fixed runtime: >>> PASS >>> # ./fio/fio --name=SW_1MB_QD32 --ioengine=libaio --direct=1 >>> --rw=write >>> --iodepth=32 --size=100% --runtime=15m --time_based --numjobs=1 >>> --bs=1m --overwrite=1 --filename=/dev/nvme2n1 >>> SW_1MB_QD32: (g=0): rw=write, bs=1M-1M/1M-1M/1M-1M, ioengine=libaio, >>> iodepth=32 >>> fio-2.3-26-g19dd >>> Starting 1 process >>> Jobs: 1 (f=1): [W(1)] [100.0% done] [0KB/1388MB/0KB /s] [0/1388/0 >>> iops] [eta 00m:00s] >>> SW_1MB_QD32: (groupid=0, jobs=1): err= 0: pid=80377: Thu Jan 14 >>> 10:28:27 2016 >>> write: io=1231.9GB, bw=1401.6MB/s, iops=1401, runt=900008msec >>> >>> Test3: Loop around max device size and continue IO with fixed total >>> IO, round total IO to bs: FAIL (does not loop around to start LBA) # >>> ./fio/fio --name=SW_1MB_QD32 --ioengine=libaio --direct=1 --rw=write >>> --iodepth=32 --size=100% --io_size=810000000000 --numjobs=1 --bs=1m >>> --overwrite=1 --filename=/dev/nvme2n1 >>> SW_1MB_QD32: (g=0): rw=write, bs=1M-1M/1M-1M/1M-1M, ioengine=libaio, >>> iodepth=32 >>> fio-2.3-26-g19dd >>> Starting 1 process >>> Jobs: 1 (f=0): [W(1)] [98.9% done] [0KB/1453MB/0KB /s] [0/1453/0 >>> iops] [eta 00m:06s] >>> SW_1MB_QD32: (groupid=0, jobs=1): err= 0: pid=81065: Thu Jan 14 >>> 10:49:53 2016 >>> write: io=763097MB, bw=1399.5MB/s, iops=1399, runt=545278msec >>> >>> Test4: Loop around max device size and continue IO with fixed total >>> IO, total IO is already aligned to bs: FAIL (does not loop around to >>> start LBA) # ./fio/fio --name=SW_1MB_QD32 --ioengine=libaio >>> --direct=1 --rw=write >>> --iodepth=32 --size=100% --io_size=810675077120 --numjobs=1 --bs=1m >>> --overwrite=1 --filename=/dev/nvme2n1 >>> SW_1MB_QD32: (g=0): rw=write, bs=1M-1M/1M-1M/1M-1M, ioengine=libaio, >>> iodepth=32 >>> fio-2.3-26-g19dd >>> Starting 1 process >>> Jobs: 1 (f=1): [W(1)] [98.6% done] [0KB/1404MB/0KB /s] [0/1404/0 >>> iops] [eta 00m:08s] >>> SW_1MB_QD32: (groupid=0, jobs=1): err= 0: pid=81339: Thu Jan 14 >>> 11:01:57 2016 >>> write: io=763097MB, bw=1399.9MB/s, iops=1399, runt=545142msec >> >> Very strange, I can't reproduce 3/4 test case failures. I've got a >> small >> nvme0n1 device here: >> >> axboe@dell:~ $ sudo blockdev --getsize64 /dev/nvme0n1 >> 4286578688 >> >> and I tried: >> >> ./fio --name=SW_1MB_QD32 --ioengine=libaio --direct=1 --rw=write >> --iodepth=1 --size=100% --io_size=4386578688 --numjobs=1 --bs=1m >> --overwrite=1 --filename=/dev/nvme0n1 >> >> and 4300000000 for sizes, and it produces the desired outcome in >> writing the bytes specified by io_size. I added a quick dump to the >> offset, and that looks correct too: >> >> [...] >> off=4281335808 >> off=4282384384 >> off=4283432960 >> off=4284481536 >> off=4285530112 >> off=0 >> off=1048576 >> off=2097152 >> off=3145728 >> [...] >> >> which loops around and starts writing from 0 again. >> >> I'll try a bigger device, though it'd be weird if that behaved >> differently. > > It does reproduce with a bigger device, just not on the 4G/16G ones I > have. Very odd, but at least I can reproduce it. It's not an absolute size, but rather one where we run into an issue if the device size isn't a multiple of the block size we use. This is a common case for real devices. Can you try current -git again? Hopefully it should be fixed. -- Jens Axboe HGST E-mail Confidentiality Notice & Disclaimer: This e-mail and any files transmitted with it may contain confidential or legally privileged information of HGST and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system. ��.n��������+%������w��{.n�������^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
