On 10/24/2014 02:47 PM, Mike Frysinger wrote: > the code seems to be fine with gcc-isms, so i might suggest anon unions > instead to make it harder to break: > union { > uint64_t __aligner; > uint16_t continue_on_error; > }; It's not a bad idea... Your commit broke alignment further down, btw, but I fixed it up. I'll be happy to take anon union patches for the alignment parts :-) -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html