io_u_log_error ddir name mismatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The names in io_u_log_error:
       const char *msg[] = { "read", "write", "sync", "datasync",
                               "sync_file_range", "wait", "trim" };

which are printed with
	log_err (msg[io_u->ddir]);

don't match the enum values for io_u->ddir:

enum fio_ddir {
        DDIR_READ = 0,
        DDIR_WRITE = 1,
        DDIR_TRIM = 2,
        DDIR_RWDIR_CNT = 3,
        DDIR_SYNC = 3,
        DDIR_DATASYNC,
        DDIR_SYNC_FILE_RANGE,
        DDIR_WAIT,
        DDIR_INVAL = -1,
};

struct io_u {
        enum fio_ddir ddir;
...

Maybe TRIM was moved earlier at some point?

My test cases just generate reads and writes, so I don't have a 
test case to validate a patch.

---
Rob Elliott    HP Server Storage


--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux