Re: [fio-2.1.9] verify and bssplit do not work together

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-07-21 20:40, Jens Axboe wrote:
But looking at the code, it won't be possible to fix, because we can
not guarantee to always have 16 4K write contiguous.

As mentioned in the original email, it's a parser fix. verify_interval
cannot be less than the minimum block size, fio will just have to catch
that and adjust / error out.

Attach should fix that - untested...

--
Jens Axboe

diff --git a/init.c b/init.c
index cf1d7f938fb3..cf2f82220f72 100644
--- a/init.c
+++ b/init.c
@@ -635,6 +635,9 @@ static int fixup_options(struct thread_data *td)
 		if (o->max_bs[DDIR_WRITE] != o->min_bs[DDIR_WRITE] &&
 		    !o->verify_interval)
 			o->verify_interval = o->min_bs[DDIR_WRITE];
+
+		if (o->verify_interval > o->min_bs[DDIR_WRITE])
+			o->verify_interval = o->min_bs[DDIR_WRITE];
 	}
 
 	if (o->pre_read) {

[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux