Re: A typo in io_u.c::get_next_file()?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-06-27 18:54, Andrey Kuzmin wrote:
diff --git a/io_u.c b/io_u.c
index e132fd9..f487b0a 100644
--- a/io_u.c
+++ b/io_u.c
@@ -1100,7 +1100,7 @@ out:

  static struct fio_file *get_next_file(struct thread_data *td)
  {
-       if (!(td->flags & TD_F_PROFILE_OPS)) {
+       if ((td->flags & TD_F_PROFILE_OPS)) {
                 struct prof_io_ops *ops = &td->prof_io_ops;

                 if (ops->get_next_file)

Hah indeed, good catch! I was wondering why it would not segfault, but I guess we fall through normally anyway. So it only impacts profiles that have get_next_file set, which makes it a minor issue.

Thanks for the patch! Applied.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux