Curious code in init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Jens,

The following code is pretty confusing for me :
http://git.kernel.dk/?p=fio.git;a=blob;f=init.c;h=c3996a76c12840e3ab3cf6514e5d5dce611a1077;hb=HEAD#l1962

The "if (nr_clients && fio_clients_connect()) {" is using the do_exit concept while being after the code that manage it and does a return -1 while exit code is set to 1.

I don't get how it should be fixed.
1- we shall move the if nr_clients before the "if (do_exit", remove the return -1 and adjust the exit_code ? 2- we shall get rid of the do_exit & exit code semantic of the if nr_clients.

What was the intent while reading the code ? ;o)

Erwan,
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux