On 2014-02-25 10:52, Jens Axboe wrote:
On 2014-02-25 09:34, Castor Fu wrote:
Indirectly. If the external engine has an option which is a
FIO_OPT_INT, and I give it a value like '4k', then we'll eventually
call fio_get_kb_base while pointing to the engine options area instead
of the options / thread_data area.
Ah I see now, yes that is definitely an issue... Let me think about this
a bit. td->eo as data only works for the engine itself, it's not pretty
that the parser ends up thinking it's td.
So the issue is really that a non static function makes assumptions
about what 'data' is at this point. That's just not going to work.
Internal use cases are fine, since they know what *data is, but it wont
work for fio_get_kb_base().
So we definitely need some way of knowing if 'data' is our regular
options or not...
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
