Re: Rip out verify_backlog support?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 5, 2014 at 11:53 AM, Jens Axboe <axboe@xxxxxxxxx> wrote:
...
>> Couldn't one shorten the defined workload and use bigger loop= instead?
>
> That's not really the same, typically you'd end up re-running the same
> thing over and over then.

Yes...unless we use a different seed on each loop. Or don't even
attempt to loop in FIO - but rather outside of FIO by the test
framework - e.g. autotest or other scripting language.

>> But in order to have strong verification without tracking IOs we need
>> to log the order that the IOs are issued, not the order they complete.
>
> My point is that you don't need to log it at all. Lets say you have a
> backlog of 500. After you have issued 500 writes, you simply reset your
> LFSR (or random generators) and re-run the same sequence as reads.

This is effectively "logging in the order issued" - just don't need to
record the LBA. We still need to track when the IO was issued and
completed. Once those stats are recorded elsewhere, we don't need to
remember the "order" since it can be reproduced.

>> Verify_backlog today requires logging IO in the order they are
>> completed. The problem is synchronizing the thread(s) that perform IO
>> vs the thread(s) that perform verification so verification isn't
>> attempted on IO that isn't complete (but is "issued" and thus logged
>> "in order issued"). The complication is IOs generally don't complete
>> in the order issued.
>
> For verify_backlog, obviously we cannot rollback the generators without
> having other synchronization between the writers and readers. So logging
> still makes more sense for that, I think. We'll just have them log in
> issue order, that doesn't seem like a big deal.

Agreed - but that synchronization doesn't exist today AFAICT.

>> And if we get "verify backlog" working correctly, then we don't need
>> two distinct phases anymore. So perhaps remove that instead.
>
> That'd be fine.

Excellent. I'll see if I can make time to add the synchronization
described above. Seems worth it to me.

thanks for the feedback!
grant
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux