On Fri, Sep 6, 2013 at 7:46 AM, Jens Axboe <axboe@xxxxxxxxx> wrote:
...
>> + if (o->verify_only) {
>> + o->do_verify = 1;
>> + o->verify = VERIFY_META;
>> + strcpy(o->ioengine, "sync");
>> + }
>
> Should be a clear warning sign! You are hard coding the verify type and
> the engine, why??
We don't need to replicate the workload for "verify_only" runs. I was
looking for the simplest possible method to verify the data integrity
- goal is to test the HW, not the rest of the system/user space
threading models/etc.
Anyway, you are right. We don't need to override user specified
parameters. Any verify_type should work and "sync" is the default
ioengine:
os/os.h:#define FIO_PREFERRED_ENGINE "sync"
> Please take a look at how this is done for the experimental_verify. The
> writes are skipped much sooner and generically, there's no need to
> enforce any sort of specific IO engine or verify type.
Didn't know about that - Juan and I will look into it.
Thanks!
grant
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
