On Mon, Jan 28 2013, Ken Raeburn wrote:
> diskutil.c: Check for overflow in disk_util.path.
> diskutil.h: Expand disk_util.path to PATH_MAX.
Good stuff, thanks. Though I think that we should just return NULL on
failing to setup the path.
And:
> + l = snprintf(du->path, sizeof(du->path), "%s/stat", path);
> + if (l < 0 || l >= sizeof(du->path)) {
cosmetically, that should never be > sizeof(du->path), but it doesn't
hurt.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
