>On 2013-01-10 12:36, majianpeng wrote:
>> If new_size was zero or realloc failed, it would be segment fault.
>> So add a check.
>
>It's a drop in the bucket, fio basically does not alloc failure
>checking. It'd be nice to improve on that, but you'd need a lot more
>than the below to get near fixing that.
>
>--
>Jens Axboe
>
yes, why did i sent this patch?Because i set nrfiles=-1,fio would be segfault.
I viewed the code about judging nrfiles, the code did not check this condition.
Anthor case can cause this bug if nrfiles=0xffffffff.
There are many parameters like nrfiles.So they should do same check.
Maybe add those check is better rather than check alloc fail or success?
Jianpeng
Thanks!
?韬{.n?????%??檩??w?{.n?????^n?■???h?璀?｛?夸z罐?+€?zf＂?????i?????_璁?:+v??撸?
