The following changes since commit 885ac623a4f154007efa49266bb381bcbc60f1e6: iolog: remove assert in io_u overlap (2012-04-04 14:11:58 -0600) are available in the git repository at: git://git.kernel.dk/fio.git master Jens Axboe (1): group reporting: fix bad values of min/max Lucian Adrian Grijincu (1): HOWTO: typo: write_log_log -> write_lat_log + use suffix HOWTO | 6 +++--- stat.c | 15 ++++++--------- 2 files changed, 9 insertions(+), 12 deletions(-) --- Diff of recent changes: diff --git a/HOWTO b/HOWTO index 73e8265..92ce05d 100644 --- a/HOWTO +++ b/HOWTO @@ -320,7 +320,7 @@ rw=str Type of io pattern. Accepted values are: one by appending a ':<nr>' to the end of the string given. For a random read, it would look like 'rw=randread:8' for passing in an offset modifier with a value of 8. If the - postfix is used with a sequential IO pattern, then the value + suffix is used with a sequential IO pattern, then the value specified will be added to the generated offset for each IO. For instance, using rw=write:4k will skip 4k for every write. It turns sequential IO into sequential IO with holes. @@ -1107,8 +1107,8 @@ write_bw_log=str If given, write a bandwidth log of the jobs in this job file. Can be used to store data of the bandwidth of the jobs in their lifetime. The included fio_generate_plots script uses gnuplot to turn these text files into nice - graphs. See write_log_log for behaviour of given - filename. For this option, the postfix is _bw.log. + graphs. See write_lat_log for behaviour of given + filename. For this option, the suffix is _bw.log. write_lat_log=str Same as write_bw_log, except that this option stores io submission, completion, and total latencies instead. If no diff --git a/stat.c b/stat.c index 26f45f4..2ab5f1a 100644 --- a/stat.c +++ b/stat.c @@ -1045,10 +1045,11 @@ void show_run_stats(void) bw = 0; if (ts->runtime[j]) { - unsigned long runt; + unsigned long runt = ts->runtime[j]; + unsigned long long kb; - runt = ts->runtime[j]; - bw = ts->io_bytes[j] / runt; + kb = ts->io_bytes[j] / rs->kb_base; + bw = kb * 1000 / runt; } if (bw < rs->min_bw[j]) rs->min_bw[j] = bw; @@ -1060,16 +1061,12 @@ void show_run_stats(void) } for (i = 0; i < groupid + 1; i++) { - unsigned long max_run[2]; - rs = &runstats[i]; - max_run[0] = rs->max_run[0]; - max_run[1] = rs->max_run[1]; if (rs->max_run[0]) - rs->agg[0] = (rs->io_kb[0] * 1000) / max_run[0]; + rs->agg[0] = (rs->io_kb[0] * 1000) / rs->max_run[0]; if (rs->max_run[1]) - rs->agg[1] = (rs->io_kb[1] * 1000) / max_run[1]; + rs->agg[1] = (rs->io_kb[1] * 1000) / rs->max_run[1]; } /* -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html