> -----Original Message----- > From: fio-owner@xxxxxxxxxxxxxxx [mailto:fio-owner@xxxxxxxxxxxxxxx] On > Behalf Of Jens Axboe > Sent: Monday, February 20, 2012 1:08 AM > To: Josh Carter > Cc: fio@xxxxxxxxxxxxxxx; Bill Hooper (whooper) > Subject: Re: Formats for log files > > On 02/16/2012 08:46 PM, Josh Carter wrote: > > Hi Bill, > > > > Looking at the code, I believe you're correct, the bandwidth logging > > for mixed loads isn't right. While read and write logs are kept > > separate, only one direction's log will get flushed on each interval. > > Instead, fio should flush both directions. > > > > I'm attaching a patch. Jens: could you take a look at this? I've > > tested both mixed and single-direction workloads, seems to work fine. > > Patch looks good, applied. Thanks! > > -- > Jens Axboe > > -- > To unsubscribe from this list: send the line "unsubscribe fio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html I did test the patch from Josh and it appears to work correctly. I noticed that the issue also exists in the iops and latency logging. I was able to use the code Josh provided to correct the iops logging. I did not spend any time attempting to correct the latency logging issue, although I suspect the fix is similar to the others. Could someone take a deeper look into this? Bill Hooper Micron -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
