Hi, This commit breaks the calculation of iops. Before this commit, the iops from group_report is 1467, see below: chenyun@xxxxxxxxxxxxxx.cm4 fio]$ sudo ./fio ~/iotest/readdev thread16: (g=0): rw=randread, bs=4K-4K/4K-4K, ioengine=sync, iodepth=1 ... thread16: (g=0): rw=randread, bs=4K-4K/4K-4K, ioengine=sync, iodepth=1 fio 1.57 Starting 10 threads Jobs: 10 (f=10): [rrrrrrrrrr] [100.0% done] [5929K/0K /s] [1447 /0 iops] [eta 00m:00s] thread16: (groupid=0, jobs=10): err= 0: pid=19538 read : io=176212KB, bw=5871.6KB/s, iops=1467 , runt= 30011msec [cut here] After this commit, the reported iops is 266, which is only one thread's output, not group_reporting, see below: [chenyun@xxxxxxxxxxxxxx.cm4 fio]$ sudo ./fio ~/iotest/readdev thread16: (g=0): rw=randread, bs=4K-4K/4K-4K, ioengine=sync, iodepth=1 ... thread16: (g=0): rw=randread, bs=4K-4K/4K-4K, ioengine=sync, iodepth=1 fio 1.57 Starting 10 threads Jobs: 10 (f=10): [rrrrrrrrrr] [100.0% done] [6033K/0K /s] [1473 /0 iops] [eta 00m:00s] thread16: (groupid=0, jobs=10): err= 0: pid=19692 read : io=351720KB, bw=1065.7KB/s, iops=266 , runt=330046msec [cut here] Thanks, Zhu Yanhai 2011/8/13 Jens Axboe <axboe@xxxxxxxxx>: > On 2011-08-12 20:52, Yu-ju Hong wrote: >> This patch introduces two new options: >> 1) Specifying --clat_percentiles enables the reporting of >> completion latency percentiles. >> 2) --percentile_list allows the user to customize the >> list of percentiles to report. > > Good feature, applied. The usage of done and !done for 'first' and > 'curr' is a little odd, at least it could warrant a comment. But > otherwise looks good. > > -- > Jens Axboe > > -- > To unsubscribe from this list: send the line "unsubscribe fio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
