On 2010-06-30 09:34, Jens Axboe wrote: > On 2010-06-30 09:31, Jens Axboe wrote: >> On 2010-06-29 21:32, Vivek Goyal wrote: >>> Hi, >>> >>> I was running latest fio and noticed that number of fields in fio >>> --minimal output have gone up from 69 to 77. A increase of 8 >>> fields. Don't see any update in --minimal documentation. Is it >>> regarding total latency thing? >> >> Woops yes, there's a total latency in there as well now. Should >> just be 4 extra fields, though. It gets logged after completion >> latency, but before bandwidth stats. I'll update the >> documentation. >> >> Should we perhaps put a versioning field in there? Now would seem >> to be a good time, since the output has changed anyway. I'm open to >> suggestions from you or other terse output users. > > How about redesigning it a bit to make it more bullet proof... We > could prefix series of fields with the value they are logging. So > for instance, the 4 completion latency fields would include a clat > prefix first: > > clat[%lu;%lu;%f;%f],foo[%lu;%lu],etc > > Would that not be more resilient to future changes? New fields would > not bother you, and reordering should also be fine. > > Any other ideas? With that change, the output would be modified from: file;0;0;131072;356015;377;0;0;0.000000;0.000000;0;0;0.000000;0.000000;0;0;0.000000;0.000000;0;0;0.000000%;0.000000;0.000000;131072;303660;442;0;0;0.000000;0.000000;0;0;0.000000;0.000000;0;0;0.000000;0.000000;0;0;0.000000%;0.000000;0.000000;99.265606%;0.367197%;95;0;343;100.0%;0.0%;0.0%;0.0%;0.0%;0.0%;0.0%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00% to id[file;0;0];overview[131072;357913;375];slat[0;0;0.000000;0.000000];clat[0;0;0.000000;0.000000];lat[0;0;0.000000;0.000000];bw[0;0;0.000000%;0.000000;0.000000];overview[131072;304348;441];slat[0;0;0.000000;0.000000];clat[0;0;0.000000;0.000000];lat[0;0;0.000000;0.000000];bw[0;0;0.000000%;0.000000;0.000000];sys[99.754601%;0.000000%;116;0;342];iodepth[100.0%;0.0%;0.0%;0.0%;0.0%;0.0%;0.0%];iolat[0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%]; The upside is that it should be easier to parse, and it's even humanly readable to a much greater extent than the current format. But let me know what you think. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
