Currently upon fio job completion, we delete the cgroups. But in the
process we also loose important debugging information presetn in cgroup
files. For example time information in blkio.time, sector information in
blkio.sectors and how many a times a group was dequeued blkio.dequeue.
Leaving the cgroups as it is, allows one to go and inspect those files
after the fio job is complete.
Secondly, cgroups might have already been created by user before fio job
started. In that case it is not very right to delete cgroups after job
completion.
Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
---
cgroup.c | 1 -
1 file changed, 1 deletion(-)
Index: fio/cgroup.c
===================================================================
--- fio.orig/cgroup.c 2010-03-31 13:29:49.000000000 -0400
+++ fio/cgroup.c 2010-03-31 13:31:55.788002620 -0400
@@ -65,7 +65,6 @@ void cgroup_kill(struct flist_head *clis
flist_for_each_safe(n, tmp, clist) {
cm = flist_entry(n, struct cgroup_member, list);
- rmdir(cm->root);
flist_del(&cm->list);
sfree(cm->root);
sfree(cm);
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
