Looks good. Thanks -radha On Tue, Nov 3, 2009 at 12:47 PM, Jens Axboe <jens.axboe@xxxxxxxxxx> wrote: > On Tue, Nov 03 2009, Jens Axboe wrote: >> On Tue, Nov 03 2009, Radha Ramachandran wrote: >> > Hi, >> > I discovered the race condition when using asynch verify with libaio engine. >> > The code assumes that because the td->cur_depth value is not 0 that >> > there is still I/O pending and issues io_getevents when the I/O was >> > actually being verified by the asynchronous verify thread. This causes >> > the code to hang. >> > >> > I have attached a patch along to fix this issue. >> >> Thanks for the fix, that is indeed a race. I'll merge your patch, but >> change the io_u->in_cur_depth to be a IO_U_F_ flag. > > This is what I commited: > > http://git.kernel.dk/?p=fio.git;a=commit;h=0c41214ff4e6f31f8df64aac37be7853aada6f1f > > Please double check, thanks! > > -- > Jens Axboe > > -- > To unsubscribe from this list: send the line "unsubscribe fio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
