On Thu, Jul 23 2009, Radha Ramachandran wrote:
> Hi,
> Is there any reason why during the verify phase, when the pattern
> verification is on, there is no meta verification done. I see why
> doing pattern verify followed by a crc/md5/sha verification can be
> redundant, but I think it is useful to have meta verify check even if
> there is pattern verification just to confirm that the data was read
> from the correct location as expected.
> If this is reasonable I have a change to check meta data after pattern
> verification where applicable:
>
>
> >git diff
> diff --git a/verify.c b/verify.c
> index 84fc015..3c8997a 100644
> --- a/verify.c
> +++ b/verify.c
> @@ -482,6 +482,12 @@ int verify_io_u(struct thread_data *td, struct io_u *io_u)
> log_err("fio: verify failed at %llu/%u\n",
> io_u->offset + hdr_num * hdr->len,
> hdr->len);
> + /*
> + * Also verify the meta data if applicable.
> + */
> + if (hdr->verify_type == VERIFY_META) {
> + ret = ret | verify_io_u_meta(hdr, td,
> io_u, hdr_num);
> + }
> continue;
> }
It looks like an oversight, I've added your patch. Thanks!
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
