Re: Fix issue related to continue_on_error option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 01 2009, Radha Ramachandran wrote:
> Hi,
> I added a change so when both the continue_on_error and fill_device
> option is on, when it hits ENOSPC issue the code ignores the error.
> 
> >git diff
> diff --git a/fio.c b/fio.c
> index fa5deab..3365bb1 100644
> --- a/fio.c
> +++ b/fio.c
> @@ -388,21 +388,29 @@ static int break_on_this_error(struct
> thread_data *td, int *retptr)
>                 else
>                         err = td->error;
> 
> -               update_error_count(td, err);
> -
>                 if (td_non_fatal_error(err)) {
>                         /*
>                          * Continue with the I/Os in case of
>                          * a non fatal error.
>                          */
> +                       update_error_count(td, err);
>                         td_clear_error(td);
>                         *retptr = 0;
>                         return 0;
> +               } else if (td->o.fill_device && err == ENOSPC) {
> +                       /*
> +                        * We expect to hit this error if
> +                        * fill_device option is set.
> +                        */
> +                       td_clear_error(td);
> +                       td->terminate = 1;
> +                       return 1;
>                 } else {
>                         /*
>                          * Stop the I/O in case of a fatal
>                          * error.
>                          */
> +                       update_error_count(td, err);
>                         return 1;
>                 }
>         }

Looks good, applied. Thanks!

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux