Awesome. Thanks -radha On Tue, Apr 21, 2009 at 11:21 PM, Jens Axboe <jens.axboe@xxxxxxxxxx> wrote: > On Wed, Apr 22 2009, Jens Axboe wrote: >> On Tue, Apr 21 2009, Radha Ramachandran wrote: >> > Hi Jens, >> > Ah right, I missed the offset. >> > My interpretation of the options was that the check needs to be that >> > the (new random block + offset) needs to be < both the real_file_size >> > and io_size. >> > >> > Iam not sure i understand what you said very well, so the fix that I have is: >> >> I read up on the code, and I think your previous patch was correct. The >> offset isn't added until later in the process, so we should indeed not >> check the offset in this location. >> >> I'll test your previous patch and add it, sorry for the noise! > > Everything appears to be in working order, I have added your fix. > Thanks! > > -- > Jens Axboe > > -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html