On Mon, Apr 20 2009, Jens Axboe wrote: > On Mon, Apr 20 2009, Jens Axboe wrote: > > On Sun, Apr 19 2009, Carl Henrik Lunde wrote: > > > Hi! I think there's a bug in the stats report: > > > > > > When I specify rate=8192 I got 8388 KiB/s in the report, which happens > > > to be 8192*1.024. > > > > > > I believe the problem is that bytes / ms is used as KiB/s. I'm not > > > sure what the correct value of "base" should be (1000 vs. 1024), but > > > it doesn't affect the result. I haven't reviewed all the reporting, > > > but at least I *think* these three are wrong. > > > > Hmm, it actually seems like the reporting is correct, but that the rate > > throttling is off by 1024/1000. So the fix is likely there somewhere, > > I'll take a look. > > Hmm nope, I think you are right, it's the reporting. Looking further... I hope it works alright now, can you check? I checked in a patch based on your patch, as far as I can tell, it's fine now. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
