Re: Fedora 11 Xen domU grub.conf timeout=0 problem with pygrub / patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 19, 2009 at 06:30:06PM +0300, Pasi Kärkkäinen wrote:
> On Wed, Aug 19, 2009 at 10:09:15AM +0000, Mark McLoughlin wrote:
> > On Wed, 2009-08-19 at 01:34 +0300, Pasi Kärkkäinen wrote:
> > 
> > > #boot=/dev/xvda
> > > default=0
> > > timeout=0
> > > splashimage=(hd0,0)/grub/splash.xpm.gz
> > > hiddenmenu
> > > title Fedora (2.6.29.4-167.fc11.i686.PAE)
> > >         root (hd0,0)
> > >         kernel /vmlinuz-2.6.29.4-167.fc11.i686.PAE ro
> > >         root=/dev/mapper/vg_f11domu-lv_root rhgb quiet
> > >         initrd /initrd-2.6.29.4-167.fc11.i686.PAE.img
> > > 
> > > 
> > > timeout=0 looks suspicious.. so I changed it to 5. 
> > > After that domU comes up OK on its own..
> > > 
> > > I changed timeout back to 0, and pygrub gets stuck again.
> > > 
> > > Is this a bug of pygrub, or a broken default grub.conf timeout value of F11?
> > 
> > timeout=0 should be fine, it sounds like a pygrub bug
> > 
> 
> Indeed. 
> 
> RHEL5.3 version of pygrub seems to work with F11 domU, but the upstream Xen
> 3.4.1 pygrub doesn't. The version numbers are the same (both are 0.6).
> 
> I'll make a diff and try to figure out the fix for this..
> 

Attached is a patch to make upstream Xen 3.4.1 pygrub work with F11 domU grub.conf timeout=0
default setting. Works for me. Change is taken from the RHEL5.3 version of pygrub.

-- Pasi

> Are you guys planning to post the RHEL5 pygrub fixes upstream? 
> 
> -- Pasi
> 
> --
> Fedora-xen mailing list
> Fedora-xen@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/fedora-xen
--- pygrub-xen341	2009-08-17 22:22:29.000000000 +0300
+++ pygrub	2009-08-19 18:39:17.000000000 +0300
@@ -447,7 +447,7 @@
                     # So we may come here even after a key has been pressed.
                     # Check both timeout and mytime to avoid exiting
                     # when we shouldn't.
-                    if timeout != -1 and mytime >= int(timeout):
+		    if mytime >= int(timeout):
                         self.isdone = True
                         break
             else:
--
Fedora-xen mailing list
Fedora-xen@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-xen

[Index of Archives]     [Fedora General]     [Fedora Music]     [Linux Kernel]     [Fedora Desktop]     [Fedora Directory]     [PAM]     [Big List of Linux Books]     [Gimp]     [Yosemite News]

  Powered by Linux