On Wed, Nov 27, 2019 at 10:35 AM pmkellly@xxxxxxxxxxxx <pmkellly@xxxxxxxxxxxx> wrote: > https://fedoraproject.org/wiki/User:Tablepc/Draft_testcase_reboot Why does it need to happen on baremetal only? Any problem discovered by this test case is sure to need a deep dive no matter baremetal or VM. One thing all my Btrfs effort has taught me is how underestimated hardware and firmware bugs are in the storage stack (and even before Btrfs, the ZFS folks knew about this which is why it was invented). A fair point about VM testing is whether the disk cache mode affects the outcome. I use unsafe because it's faster and I embrace misery. I think QA bots are now mostly using unsafe because it's faster too. So depending on the situation it may be true that certain corruptions are expected if unsafe is used, but I *think* unsafe is only unsafe in the event the host crashes or experiences a power failure. I do forced power offs of VMs all the time and never lose anything, in the case of ext4 and XFS, journal replay always makes the file system consistent again. And journal replay in that example is expected, not a bug. How to test, step 2 and 3: This only applies to FAT and ext4. XFS and Btrfs have no fsck, both depend on log replay if there was an unclean shutdown. Also, there are error messages for common unclean shutdowns, and error messages for uncommon problems. I think we only care about the former, correct? Steps 4-7: I'm not following the purpose of these steps. What I'd like to see for step 4, is, if we get a bad result (any result 2 messages), we need to collect the journal for the prior boot: `sudo journalctl -b-1 > journal.log` and attach to a bug report; or we could maybe parse for systemd messages suggesting it didn't get everything unmounted. But offhand I don't know what those messages would be, I'd have to go dig into systemd code to find them. -- Chris Murphy _______________________________________________ test mailing list -- test@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to test-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/test@xxxxxxxxxxxxxxxxxxxxxxx
