The following Fedora 25 Security updates need testing: Age URL 94 https://bodhi.fedoraproject.org/updates/FEDORA-2016-d79ba708cb exim-4.87.1-1.fc25 15 https://bodhi.fedoraproject.org/updates/FEDORA-2017-06f4b88ceb php-onelogin-php-saml-2.10.5-1.fc25 7 https://bodhi.fedoraproject.org/updates/FEDORA-2017-71e69a691b pcs-0.9.156-2.fc25 6 https://bodhi.fedoraproject.org/updates/FEDORA-2017-99ad80f109 python-sleekxmpp-1.3.2-1.fc25 0 https://bodhi.fedoraproject.org/updates/FEDORA-2017-7e5b5201e7 xen-4.7.2-4.fc25 0 https://bodhi.fedoraproject.org/updates/FEDORA-2017-674d306f51 icecat-52.0.1-5.fc25 0 https://bodhi.fedoraproject.org/updates/FEDORA-2017-7bd002b77c xorgxrdp-0.2.1-1.fc25 xrdp-0.9.2-1.fc25 0 https://bodhi.fedoraproject.org/updates/FEDORA-2017-c22a1dbe8b samba-4.5.8-0.fc25 0 https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff6940bf63 chromium-57.0.2987.133-1.fc25 The following Fedora 25 Critical Path updates have yet to be approved: Age URL 2 https://bodhi.fedoraproject.org/updates/FEDORA-2017-ea86a8123b pungi-4.1.14-1.fc25 0 https://bodhi.fedoraproject.org/updates/FEDORA-2017-c22a1dbe8b samba-4.5.8-0.fc25 0 https://bodhi.fedoraproject.org/updates/FEDORA-2017-aaa2f5c814 cups-2.2.0-6.fc25 0 https://bodhi.fedoraproject.org/updates/FEDORA-2017-e6b942c07a hawkey-0.6.4-2.fc25 dnf-plugins-core-0.1.21-5.fc25 The following builds have been pushed to Fedora 25 updates-testing chromium-57.0.2987.133-1.fc25 ecj-4.6.3-1.fc25 eclipse-cdt-9.2.1-2.fc25 eclipse-dltk-5.7.1-1.fc25 eclipse-linuxtools-5.3.1-1.fc25 eclipse-mdt-uml2-5.2.3-1.fc25 eclipse-mpc-1.5.4-1.fc25 eclipse-mylyn-3.21.0-4.fc25 eclipse-photran-9.1.2-1.fc25 eclipse-ptp-9.1.2-1.fc25 eclipse-tm-terminal-4.2.0-1.fc25 eclipse-usage-4.4.3-1.fc25 gap-4.8.7-1.fc25 gap-pkg-factint-1.5.4-1.fc25 glusterfs-3.10.1-1.fc25 gotun-0-0.1.gita9dbe4d.fc25 groonga-7.0.1-1.fc25 lynis-2.4.8-1.fc25 mame-0.184-1.fc25 perl-Module-Build-0.42.22-1.fc25 php-aws-sdk3-3.25.0-1.fc25 pluma-1.16.1-1.fc25 python-bugzilla-2.1.0-1.fc25 qcad-3.16.7.0-1.fc25 rpkg-1.49-2.fc25 samba-4.5.8-0.fc25 scap-security-guide-0.1.32-1.fc25 starcal-3.0.6-1.fc25 tomcat-8.0.42-1.fc25 xorgxrdp-0.2.1-1.fc25 xrdp-0.9.2-1.fc25 Details about builds: ================================================================================ chromium-57.0.2987.133-1.fc25 (FEDORA-2017-ff6940bf63) A WebKit (Blink) powered web browser -------------------------------------------------------------------------------- Update Information: Security fix for CVE-2017-5055, CVE-2017-5054, CVE-2017-5052, CVE-2017-5056, CVE-2017-5053 -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437353 - CVE-2017-5053 chromium-browser: out of bounds memory access in v8 https://bugzilla.redhat.com/show_bug.cgi?id=1437353 [ 2 ] Bug #1437352 - CVE-2017-5056 chromium-browser: use after free in blink https://bugzilla.redhat.com/show_bug.cgi?id=1437352 [ 3 ] Bug #1437351 - CVE-2017-5052 chromium-browser: bad cast in blink https://bugzilla.redhat.com/show_bug.cgi?id=1437351 [ 4 ] Bug #1437350 - CVE-2017-5054 chromium-browser: heap buffer overflow in v8 https://bugzilla.redhat.com/show_bug.cgi?id=1437350 [ 5 ] Bug #1437348 - CVE-2017-5055 chromium-browser: use after free in printing https://bugzilla.redhat.com/show_bug.cgi?id=1437348 -------------------------------------------------------------------------------- ================================================================================ ecj-4.6.3-1.fc25 (FEDORA-2017-797cf08949) Eclipse Compiler for Java -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ eclipse-cdt-9.2.1-2.fc25 (FEDORA-2017-797cf08949) Eclipse C/C++ Development Tools (CDT) plugin -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ eclipse-dltk-5.7.1-1.fc25 (FEDORA-2017-797cf08949) Dynamic Languages Toolkit (DLTK) Eclipse plug-in -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ eclipse-linuxtools-5.3.1-1.fc25 (FEDORA-2017-797cf08949) Linux specific Eclipse plugins -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ eclipse-mdt-uml2-5.2.3-1.fc25 (FEDORA-2017-797cf08949) Implementation of the UML2 OMG meta-model for Eclipse -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ eclipse-mpc-1.5.4-1.fc25 (FEDORA-2017-797cf08949) Eclipse Marketplace Client -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ eclipse-mylyn-3.21.0-4.fc25 (FEDORA-2017-797cf08949) Eclipse Mylyn main feature. -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ eclipse-photran-9.1.2-1.fc25 (FEDORA-2017-797cf08949) Fortran Development Tools (Photran) for Eclipse -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ eclipse-ptp-9.1.2-1.fc25 (FEDORA-2017-797cf08949) Eclipse Parallel Tools Platform -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ eclipse-tm-terminal-4.2.0-1.fc25 (FEDORA-2017-797cf08949) Terminal plug-in for Eclipse -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ eclipse-usage-4.4.3-1.fc25 (FEDORA-2017-797cf08949) Usage reporting plug-ins for Eclipse -------------------------------------------------------------------------------- Update Information: Updates to Neon.3 releases. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437415 - FTBFS crash when compiling org.eclipse.cdt.core https://bugzilla.redhat.com/show_bug.cgi?id=1437415 -------------------------------------------------------------------------------- ================================================================================ gap-4.8.7-1.fc25 (FEDORA-2017-8f15b6c348) Computational discrete algebra -------------------------------------------------------------------------------- Update Information: See https://www.gap-system.org/Manuals/doc/changes/chap2.html#X80D572C87D430AC0 for changes in this release. -------------------------------------------------------------------------------- ================================================================================ gap-pkg-factint-1.5.4-1.fc25 (FEDORA-2017-9ec3ff6672) Advanced methods for factoring integers -------------------------------------------------------------------------------- Update Information: Changes in version 1.5.4: - The directory factint/gap/ has been renamed to factint/lib/, in order to follow the same naming convention as for the subdirectories of the GAP root directory. - The file factint/doc/manual.js has been added. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437696 - gap-pkg-factint-1.5.4 is available https://bugzilla.redhat.com/show_bug.cgi?id=1437696 -------------------------------------------------------------------------------- ================================================================================ glusterfs-3.10.1-1.fc25 (FEDORA-2017-caf7d57ce5) Distributed File System -------------------------------------------------------------------------------- Update Information: 3.10.1 GA -------------------------------------------------------------------------------- ================================================================================ gotun-0-0.1.gita9dbe4d.fc25 (FEDORA-2017-b69936e6e0) Tool to run tests on OpenStack -------------------------------------------------------------------------------- Update Information: Updates with command line flags -------------------------------------------------------------------------------- ================================================================================ groonga-7.0.1-1.fc25 (FEDORA-2017-63c123aa66) An Embeddable Fulltext Search Engine -------------------------------------------------------------------------------- Update Information: See http://groonga.org/en/blog/2017/03/29/groonga-7.0.1.html -------------------------------------------------------------------------------- References: [ 1 ] Bug #1420563 - groonga-7.0.1 is available https://bugzilla.redhat.com/show_bug.cgi?id=1420563 [ 2 ] Bug #1415675 - groonga-6.1.5 is available https://bugzilla.redhat.com/show_bug.cgi?id=1415675 -------------------------------------------------------------------------------- ================================================================================ lynis-2.4.8-1.fc25 (FEDORA-2017-65db9aa1fd) Security and system auditing tool -------------------------------------------------------------------------------- Update Information: Update to 2.4.8 -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437271 - lynis-2.4.8 is available https://bugzilla.redhat.com/show_bug.cgi?id=1437271 -------------------------------------------------------------------------------- ================================================================================ mame-0.184-1.fc25 (FEDORA-2017-80416b0c78) Multiple Arcade Machine Emulator -------------------------------------------------------------------------------- Update Information: An update to the latest mame release: * http://mamedev.org/?p=441 -------------------------------------------------------------------------------- ================================================================================ perl-Module-Build-0.42.22-1.fc25 (FEDORA-2017-bb0ae39f06) Build and install Perl modules -------------------------------------------------------------------------------- Update Information: This release fixes running on Perl without "." in @INC path. It also removes useless warning about Module::Build deprecation. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1437701 - perl-Module-Build-0.4222 is available https://bugzilla.redhat.com/show_bug.cgi?id=1437701 -------------------------------------------------------------------------------- ================================================================================ php-aws-sdk3-3.25.0-1.fc25 (FEDORA-2017-744f3a49b3) Amazon Web Services framework for PHP -------------------------------------------------------------------------------- Update Information: ## 3.25.0 - 2017-03-31 * `Aws\CloudFormation` - Adding paginators for ListExports and ListImports * `Aws\CloudFront` - Amazon CloudFront now supports user configurable HTTP Read and Keep-Alive Idle Timeouts for your Custom Origin Servers * `Aws\ResourceGroupsTaggingAPI` - Resource Groups Tagging APIs can help you organize your resources and enable you to simplify resource management, access management, and cost allocation. * `Aws\StorageGateway` - File gateway mode in AWS Storage gateway provides access to objects in S3 as files on a Network File System (NFS) mount point. Once a file share is created, any changes made externally to the S3 bucket will not be reflected by the gateway. Using the cache refresh feature in this update, the customer can trigger an on-demand scan of the keys in their S3 bucket and refresh the file namespace cached on the gateway. It takes as an input the fileShare ARN and refreshes the cache for only that file share. Additionally there is new functionality on file gateway that allows you configure what squash options they would like on their file share, this allows a customer to configure their gateway to not squash root permissions. This can be done by setting options in NfsOptions for CreateNfsFileShare and UpdateNfsFileShare APIs. ## 3.24.9 - 2017-03-28 * `Aws\Batch` - Customers can now provide a retryStrategy as part of the RegisterJobDefinition and SubmitJob API calls. The retryStrategy object has a number value for attempts. This is the number of non successful executions before a job is considered FAILED. In addition, the JobDetail object now has an attempts field and shows all execution attempts. * `Aws\EC2` - Customers can now tag their Amazon EC2 Instances and Amazon EBS Volumes at the time of their creation. You can do this from the EC2 Instance launch wizard or through the RunInstances or CreateVolume APIs. By tagging resources at the time of creation, you can eliminate the need to run custom tagging scripts after resource creation. In addition, you can now set resource-level permissions on the CreateVolume, CreateTags, DeleteTags, and the RunInstances APIs. This allows you to implement stronger security policies by giving you more granular control over which users and groups have access to these APIs. You can also enforce the use of tagging and control what tag keys and values are set on your resources. When you combine tag usage and resource-level IAM policies together, you can ensure your instances and volumes are properly secured upon creation and achieve more accurate cost allocation reporting. These new features are provided at no additional cost. ## 3.24.8 - 2017-03-27 * `Aws\SSM` - Updated validation rules for SendCommand and RegisterTaskWithMaintenanceWindow APIs ## 3.24.7 - 2017-03-23 * `Aws\ApplicationAutoScaling` - Application AutoScaling is launching support for a new target resource (AppStream 2.0 Fleets) as a scalable target. ## 3.24.6 - 2017-03-22 * `Aws\ApplicationDiscoveryService` - Adds export configuration options to the AWS Discovery Service API. * `Aws\ElasticLoadBalancingv2` - Adding waiters for Elastic Load Balancing V2 * `Aws\Lambda` - Adds support for new runtime Node.js v6.10 for AWS Lambda service ## 3.24.5 - 2017-03-21 * `Aws\DirectConnect` - Deprecated DescribeConnectionLoa, DescribeInterconnectLoa, AllocateConnectionOnInterconnect and DescribeConnectionsOnInterconnect operations in favor of DescribeLoa, DescribeLoa, AllocateHostedConnection and DescribeHostedConnections respectively. * `Aws\MarketplaceCommerceAnalytics` - This update adds a new data set, us_sales_and_use_tax_records, which enables AWS Marketplace sellers to programmatically access to their U.S. Sales and Use Tax report data. * `Aws\Pinpoint` - Added support for segment endpoints by user attributes in addition to endpoint attributes, publishing raw app analytics and campaign events as events streams to Kinesis and Kinesis Firehose ## 3.24.4 - 2017-03-14 * `Aws\CloudWatchEvents` - Update documentation ## 3.24.3 - 2017-03-13 * `Aws\CloudWatchEvents` - This update extends Target Data Type for configuring Target behavior during invocation. * `Aws\DeviceFarm` - Network shaping allows users to simulate network connections and conditions while testing their Android, iOS, and web apps with AWS Device Farm. ## 3.24.2 - 2017-03-10 * `Aws\CodeDeploy` - Add paginators for Codedeploy * `Aws\EMR` - This release includes support for instance fleets in Amazon EMR. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1431302 - php-aws-sdk3-3.25.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1431302 -------------------------------------------------------------------------------- ================================================================================ pluma-1.16.1-1.fc25 (FEDORA-2017-aad1da140f) Text editor for the MATE desktop -------------------------------------------------------------------------------- Update Information: - update to 1.16.1 - fix running under wayland -------------------------------------------------------------------------------- References: [ 1 ] Bug #1387496 - segfault when launch twice https://bugzilla.redhat.com/show_bug.cgi?id=1387496 -------------------------------------------------------------------------------- ================================================================================ python-bugzilla-2.1.0-1.fc25 (FEDORA-2017-3c626bbda2) python2 library for interacting with Bugzilla -------------------------------------------------------------------------------- Update Information: * Rebased to version 2.1.0 * Support for bugzilla 5 API Keys (Dustin J. Mitchell) * bugzillarc can be used to set default URL for the cli tool * Revive update_flags wrapper * Bug fixes and minor improvements ---- * Rebased to version 2.0.0 * Several fixes for use with bugzilla 5 * This release contains several smallish API breaks: * Bugzilla.bug_autorefresh now defaults to False * Credentials are now cached in ~/.cache/python-bugzilla/ * bin/bugzilla was converted to argparse * bugzilla query --boolean_chart option is removed * Unify command line flags across sub commands -------------------------------------------------------------------------------- ================================================================================ qcad-3.16.7.0-1.fc25 (FEDORA-2017-1123ec9e9b) Powerful 2D CAD system -------------------------------------------------------------------------------- Update Information: - Update to 3.16.7.0 - Fix detection of QCAD modules -------------------------------------------------------------------------------- ================================================================================ rpkg-1.49-2.fc25 (FEDORA-2017-8f90ef2439) Python library for interacting with rpm+git -------------------------------------------------------------------------------- Update Information: Rename pyrpkg to python2-rpkg. Currently, only Python 2 package is available. Test cases: - installing ``python2-rpkg`` will replace ``pyrpkg`` with ``python2-rpkg`` - installing ``fedpkg`` should select ``python2-rpkg`` - original package ``rpkg``, which contains example CLI, is moved to ``%{_datadir}/rpkg/examples/cli`` -------------------------------------------------------------------------------- References: [ 1 ] Bug #1400592 - Rename subpackage pyrpkg to python2-rpkg https://bugzilla.redhat.com/show_bug.cgi?id=1400592 -------------------------------------------------------------------------------- ================================================================================ samba-4.5.8-0.fc25 (FEDORA-2017-c22a1dbe8b) Server and Client software to interoperate with Windows machines -------------------------------------------------------------------------------- Update Information: Security fix for CVE-2017-2619 -------------------------------------------------------------------------------- References: [ 1 ] Bug #1429472 - CVE-2017-2619 samba: symlink race permits opening files outside share directory https://bugzilla.redhat.com/show_bug.cgi?id=1429472 -------------------------------------------------------------------------------- ================================================================================ scap-security-guide-0.1.32-1.fc25 (FEDORA-2017-801eec01a6) Security guidance and baselines in SCAP formats -------------------------------------------------------------------------------- Update Information: updated to latest upstream release ---- update to the latest upstream release -------------------------------------------------------------------------------- ================================================================================ starcal-3.0.6-1.fc25 (FEDORA-2017-af250554b2) A full-featured international calendar written in Python -------------------------------------------------------------------------------- Update Information: Upstream bugfix release -------------------------------------------------------------------------------- References: [ 1 ] Bug #1431416 - starcal-3.0.6 is available https://bugzilla.redhat.com/show_bug.cgi?id=1431416 -------------------------------------------------------------------------------- ================================================================================ tomcat-8.0.42-1.fc25 (FEDORA-2017-a88e3921c6) Apache Servlet/JSP Engine, RI for Servlet 3.1/JSP 2.3 API -------------------------------------------------------------------------------- Update Information: This updates includes a rebase from tomcat 8.0.41 up to 8.0.42. -------------------------------------------------------------------------------- ================================================================================ xorgxrdp-0.2.1-1.fc25 (FEDORA-2017-7bd002b77c) Implementation of xrdp backend as Xorg modules -------------------------------------------------------------------------------- Update Information: New upstream version of xorgxrdp and xrdp: New features in xrdp: - RemoteFX codec support is now enabled by default. - Bitmap updates support is now enabled by default. - TLS ciphers suites and version is now logged. - Connected computer name is now logged. - Switched to Xorg (xorgxrdp) as the default backend now. - Miscellaneous RemoteFX codec mode improvements. - Socket directory is configurable at the compile time. Bugfixes in xrdp: - Parallels client for MacOS / iOS can now connect (audio redirection must be disabled on client or xrdp server though). - MS RDP client for iOS can now connect using TLS security layer. - MS RDP client for Android can now connect to xrdp. - Large resolutions (4K) can be used with RemoteFX graphics. - Multiple RemoteApps can be opened throguh NeutrinoRDP proxy. - tls_ciphers in xrdp.ini is not limited to 63 chars anymore, it's variable-length. - Fixed an issue where tls_ciphers were ignored and rdp security layer could be used instead. - Kill disconnected sessions feature is working with Xorg (xorgxrdp) backend. - Miscellaneous code cleanup and memory issues fixes. Rebuild of xrdp requiring both xorgxrdp and tigervnc- minimal. VNC is still the default. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1433959 - CVE-2017-6967 xrdp: Incorrect placement of auth_start_session() [fedora-all] https://bugzilla.redhat.com/show_bug.cgi?id=1433959 -------------------------------------------------------------------------------- ================================================================================ xrdp-0.9.2-1.fc25 (FEDORA-2017-7bd002b77c) Open source remote desktop protocol (RDP) server -------------------------------------------------------------------------------- Update Information: New upstream version of xorgxrdp and xrdp: New features in xrdp: - RemoteFX codec support is now enabled by default. - Bitmap updates support is now enabled by default. - TLS ciphers suites and version is now logged. - Connected computer name is now logged. - Switched to Xorg (xorgxrdp) as the default backend now. - Miscellaneous RemoteFX codec mode improvements. - Socket directory is configurable at the compile time. Bugfixes in xrdp: - Parallels client for MacOS / iOS can now connect (audio redirection must be disabled on client or xrdp server though). - MS RDP client for iOS can now connect using TLS security layer. - MS RDP client for Android can now connect to xrdp. - Large resolutions (4K) can be used with RemoteFX graphics. - Multiple RemoteApps can be opened throguh NeutrinoRDP proxy. - tls_ciphers in xrdp.ini is not limited to 63 chars anymore, it's variable-length. - Fixed an issue where tls_ciphers were ignored and rdp security layer could be used instead. - Kill disconnected sessions feature is working with Xorg (xorgxrdp) backend. - Miscellaneous code cleanup and memory issues fixes. Rebuild of xrdp requiring both xorgxrdp and tigervnc- minimal. VNC is still the default. -------------------------------------------------------------------------------- References: [ 1 ] Bug #1433959 - CVE-2017-6967 xrdp: Incorrect placement of auth_start_session() [fedora-all] https://bugzilla.redhat.com/show_bug.cgi?id=1433959 -------------------------------------------------------------------------------- _______________________________________________ test mailing list -- test@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to test-leave@xxxxxxxxxxxxxxxxxxxxxxx