Le mercredi 27 février 2019 à 11:21 -0600, Jason L Tibbitts III a écrit : > > > > > > "FW" == Florian Weimer <fweimer@xxxxxxxxxx> writes: > > FW> Is this really a good idea? As a result, it can be very difficult > FW> to modify the changed files again in a subsequent patch. > > That would be the case for any conditionally applied patch, and > wouldn't > really argue against a convenience macro to allow %autosetup to still > be > used. But still, this kind of patches should be rare for many good > reasons which is why I never tried to get such a macro into our RPM > configuration. The whole autosetup patching thing does not really work if you have more than one SOURCE than needs patching. Last time I looked at it, I came to the conclusion that it would just be nicer to define a variable with the list and order of patches to apply to a particular source (an undefined variable meaning everything like now). And once you have that, you get conditional patching for free, since the variable can be set inside a conditional block. That nicely dissociates the patches recorded in the srpm (everything) from the patches effectively applied. Quite useful for bootstrap- specific patches for example Regards, -- Nicolas Mailhot _______________________________________________ packaging mailing list -- packaging@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to packaging-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx
