On Sun, Feb 24, 2019 at 9:43 PM Todd Zullinger <tmz@xxxxxxxxx> wrote:
>
> Hi,
>
> Nico Kadel-Garcia wrote:
> > On Sat, Feb 23, 2019 at 7:42 PM Todd Zullinger <tmz@xxxxxxxxx> wrote:
> >
> >> Patch5: number5.patch
> >> %if 0%{?fedora} > 29
> >> Patch6: fedora-30-and-above.patch
> >> %endif
> >
> > *Never* do this. If you do this, your different SRPM's have different
> > content, and any attempt to port the content to a release not included
> > by the "%if" will not have the patch referred to.
>
> Yes, it has drawbacks. :)
>
> How significant those are depend upon whether we consider
> dist-git or generated srpm files as the canonical source.
> If it's dist-git, then this is much less of an issue than if
> it's the srpm files.
>
> That's not to say that even if dist-git is canonical that
> we want to allow srpm's to differ across releases and/or any
> other conditions an %if allows.
>
> I did expect the guidelines might contain something on the
> subject. I know it's come up in the past. Part of the
> reason I put it out here was to see if it jogged any
> memories of whether: a) it's in the guidelines and I have
> overlooked it; b) it was previously in the guidelines and
> lost to time; or c) it's just one of those things which
> long-time rpm folks pick up over the years.
>
I'm pretty sure this rule has existed in the guidelines before. But
with everything juggled around from the wiki into the new Antora-based
system, it probably got lost somewhere...
--
真実はいつも一つ！/ Always, there's only one truth!
_______________________________________________
packaging mailing list -- packaging@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to packaging-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx
