On 19. 01. 19 0:19, Jordan Ogas wrote:
At the end we went with a rpmlint config fiel that simply silences those errors.
See our config file here:
https://src.fedoraproject.org/rpms/python3/blob/master/f/python3.rpmlintrc
And information about how to use it is located here:
https://fedoraproject.org/wiki/Taskotron/Tasks/dist.rpmlint
https://github.com/rpm-software-management/rpmlint#configuration
Very insightful, thank you. Question: how do the fedora/epel reviewers handle reviews with rpmlint config files, like the one you linked here? Do you submit the rpmlint config file along with the spec file? Perhaps a justification as well?
The rpmlint output must be part of the review. However if rpmlint gives errors
and a justification is provided, it is not a blocker for the package to get
accepted.
So I'd say:
* always provide justification, especially if the case is not obvious
* optionally provide a config file as well if you intend to use it
rpmlint can be wrong, see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_use_rpmlint
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
packaging mailing list -- packaging@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to packaging-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx
