On 12/08/2017 08:03 PM, nicolas.mailhot@xxxxxxxxxxx wrote:
Hi,
I am proposing for inclusion a macro set aimed at automating the packaging of forge-hosted projects.
— Packaging draft: https://fedoraproject.org/wiki/Forge-hosted_projects_packaging_automation
— FPC ticket: https://pagure.io/packaging-committee/issue/719 (without the “hasdraft” tag because I don't know how to add it in pagure)
— fedora-rpm-macros RFE with the macro file: https://bugzilla.redhat.com/show_bug.cgi?id=1523779
What it does: conversion of a forge url, version, tag, commit set to the values expected in rpm specfiles, in optional rpm variables. Computation of the corresponding %{dist}.
Objective: centralize forge structure know-how in a single technical place, deprecate all the complex manual forge URL handling spread over many Fedora spec files, simplify packaging and spend time on more interesting stuff.
Kudos for work on reducing repetitive complex error prone cruft in specs!
But don't override %setup. There's no need for such abuse (yes
overriding rpm build-ins is abuse even if it still doesn't prevent it)
and no good will come out of it.
Use something like %forgesetup instead which signifies it's something a
bit special, and allows you to %autosetup underneath on versions where
macro arguments are expanded (rpm >= 4.14)
- Panu -
_______________________________________________
packaging mailing list -- packaging@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to packaging-leave@xxxxxxxxxxxxxxxxxxxxxxx
