Re: github SourceURL improvement

[Japheth Cleaver <cleaver@xxxxxxxxxxxxxx>]

On 1/9/2016 11:08 AM, Dave Johansen wrote:

On Fri, Jan 8, 2016 at 6:08 PM, Sérgio Basto <sergio@xxxxxxxxxx> wrote:

Hi,

On Sáb, 2015-12-26 at 04:39 +0000, Sérgio Basto wrote:
> Hi,
> At list for github we can remove ".tar.gz#" [1] may (or should) I
> update the wiki ? 
>
> -Source0:  https://github.com/OWNER/%{name}/archive/%{commit0}.tar.gz
> #/%{name}-%{shortcommit0}.tar.gz
> +Source0:  https://github.com/OWNER/%{name}/archive/%{commit0}/%{name
> }-%{shortcommit0}.tar.gz

I think was Germano that found this formula, previous email demonstrate
that works for commit revision but also works for git tags and  
releases. 
Instead source url be like this :  
https://github.com/besser82/pipelight-selinux/archive/v0.3.1.tar.gz#/pi
pelight-selinux-0.3.1.tar.gz

Could be like this: 
https://github.com/besser82/pipelight-selinux/archive/v0.3.1/pipelight-
selinux-0.3.1.tar.gz

The previous discussion brought up that while tags shouldn't change, nothing enforces that and some upstreams might do that. That was the major argument for using the commit that corresponds to the tag instead of the tag itself.

Upstreams could just as easily replace a simple tarball on a site as well though. It seems like there should be a certain level of sanity-expectation for what upstreams are doing, and if it violates generally-expected norms then to call that out as such.

If no release tags are ever made, that's one thing... but it feels like if a release tag is present we should be using that.

-jc

--
packaging mailing list
packaging@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/packaging@xxxxxxxxxxxxxxxxxxxxxxx