On Tue, Jun 23, 2015 at 8:11 AM, Remi Collet <Fedora@xxxxxxxxxxxxxxxxx> wrote:
Le 18/04/2015 22:28, Dave Johansen a écrit :
> What's the right way to handle github URLs? Currently,
I think Guidelines are clear.
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github
"For a number of reasons (immutability, availability,
uniqueness), you must use the full commit revision hash
when referring to the sources."
> I'm working on the
> spec file for breathe and the URL is
> https://github.com/michaeljones/breathe/archive/v4.0.0.tar.gz and the
AFAIK, this is NOT immutable (upstream can delete/update tag) so not valid.
I believe it's true that the tag can be deleted or changed, which could cause problems with reproducability. I changed the above URL to use the hash of the commit and that gives the same results but with the guarantee of being reproducible. For the sake of documentation, here's the updated lines from the .spec:
%global owner michaeljones
%global commit0 aa95a879dccd63cfac5156bd9a303d41ea1d2490
Name: breathe
Source0: https://github.com/%{owner}/%{name}/archive/%{name}-%{commit0}.tar.gz
%setup -qn %{name}-%{commit0}
%global owner michaeljones
%global commit0 aa95a879dccd63cfac5156bd9a303d41ea1d2490
Name: breathe
Source0: https://github.com/%{owner}/%{name}/archive/%{name}-%{commit0}.tar.gz
%setup -qn %{name}-%{commit0}
-- packaging mailing list packaging@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/packaging
