On Mon, Apr 30, 2012 at 9:11 AM, "Germán A. Racca" <german.racca@xxxxxxxxx> wrote: > On 04/30/2012 10:57 AM, Jon Ciesla wrote: >> >> On Mon, Apr 30, 2012 at 8:56 AM, Jon Ciesla<limburgher@xxxxxxxxx> wrote: >>> >>> On Mon, Apr 30, 2012 at 8:50 AM, "Germán A. Racca" >>> <german.racca@xxxxxxxxx> wrote: >>>> >>>> Hi list: >>>> >>>> I'm the packager of APLpy: http://aplpy.github.com/ >>>> >>>> I'm going to update it to a new version, which comes with a set of >>>> tests, >>>> but I'm not sure about what to do with them. I asked upstream and the >>>> answer >>>> is: >>>> >>>> "The tests are there for us to diagnose any issues related to specific >>>> dependency versions and platforms, and to make sure that we don't >>>> break anything when making changes. It would be useful if you include >>>> them so that we can ask users to run them if they are having issues we >>>> can't reproduce, but you don't need to run the tests as part of the >>>> build/setup." >>>> >>>> I'm still not sure. Should I include them in the package? >>> >>> >>> Unless they impose huge build deps or something, run them in make check. >> >> >> To more directly answer your question, yes, include and run tests >> whenever possible. :) > > > Thanks Jon :) > > This is a Python package. Under what directory should I put them? For users, probably in %doc. > The tests ran fine in my computer[*], but what should I do in case of a > negative outcome? If they're in make check in the spec, if they fail, the RPM build will fail. -J > Germán. > > [*] $ python runtests.py > =================== test session starts ==================== > platform linux2 -- Python 2.7.2 -- pytest-2.2.0 > collected 186 items > > tests/test_axis_labels.py ...... > tests/test_beam.py ................ > tests/test_colorbar.py ....... > tests/test_contour.py .. > tests/test_downsample.py . > tests/test_frame.py .. > tests/test_grid.py ....... > tests/test_init_cube.py ............................ > tests/test_init_image.py > ........................................................................ > tests/test_save.py ........................ > tests/test_scalebar.py .......... > tests/test_tick_labels.py ..... > tests/test_ticks.py ...... > > =============== 186 passed in 106.97 seconds =============== > > -- > Germán A. Racca > Fedora Package Maintainer > https://fedoraproject.org/wiki/User:Skytux > -- > packaging mailing list > packaging@xxxxxxxxxxxxxxxxxxxxxxx > https://admin.fedoraproject.org/mailman/listinfo/packaging -- http://cecinestpasunefromage.wordpress.com/ ------------------------------------------------ in your fear, seek only peace in your fear, seek only love -d. bowie -- packaging mailing list packaging@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/packaging
