Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477190 --- Comment #2 from Adam Stokes <astokes@xxxxxxxxxx> 2008-12-19 11:14:13 EDT --- (In reply to comment #1) > Okay, a few things to start with: > > * Please don't use a source file for Version/Release. That's what the spec file > is for. > * You can't use "GPL" as a license tag, see: > https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#GPL_and_LGPL Thanks, set to GPLv3 > * Please put the full upstream path to your sources in your Source definitions. Fixed > * Run rpmlint on the packages (both SRPM and noarch RPM) and make sure you've > silenced the output. [adam@conans cas]$ rpmlint -i ~/redhat/cas/noarch/cas-0.13-113.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [adam@conans cas]$ rpmlint -i ~/redhat/cas/cas-0.13-113.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > > When you've made these changes, be sure to increment Release and add a new > changelog entry describing the changes that you've made. Once that's done, post > a new SRPM and spec file and I'll pick up the review. Done SRPM: http://astokes.fedorapeople.org/cas-0.13-113.src.rpm SPEC: http://astokes.fedorapeople.org/cas.spec thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review