Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470737 --- Comment #4 from Itamar Reis Peixoto <itamar@xxxxxxxxxxxxxxxx> 2008-12-18 15:39:46 EDT --- > Some remarks: > > - Don't mix $RPM_BUILD_ROOT and %{buildroot} fixed -%{__chmod} 0644 $RPM_BUILD_DIR/%{name}-%{version}/penstats +%{__chmod} 0644 %{_builddir}/%{name}-%{version}/penstats > https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS > > - You should report upstream about the missing pen.conf in the release tarball. the pen.conf file in /etc/httpd/conf.d/ is inside .spec file in pen tarball, but I have put it ouside spec file to make it more compatible with fedora and make this spec file clean. > - What's about a restart of apache after the installation? > https://fedoraproject.org/wiki/Packaging/SysVInitScript the penctl.cgi cgi is basically for statistics, I will let it without restarting apache for the moment. here are the lasted version.. http://ispbrasil.com.br/pen/pen.spec http://ispbrasil.com.br/pen/pen-0.18.0-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review