[Bug 452413] Review Request: BkChem - Chemical drawing program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=452413





--- Comment #27 from Henrique "LonelySpooky" Junior <henriquecsj@xxxxxxxxx>  2008-12-18 07:58:25 EDT ---
Here are the changes:
* The name of the patch was changed to something more self explanatory
"bkchem-exclude-oasa-piddle-pmw.patch";
* The license was added as GPLv2+ and GFDL;
* The changelog explains about the adoption of the patch and what the patch
does;
* Rpmlint is not showing errors.

In fact, the patch is absurdly large, 1.3 MB. Is it better to simply change the
patch to rm commands directly into the file .spec and apply the patch only in
the file setup.py?

SPEC: http://lspooky.fedorapeople.org/bkchem/0.12.5/2/bkchem.spec
PATCH:
http://lspooky.fedorapeople.org/bkchem/0.12.5/2/bkchem-exclude-oasa-piddle-pmw.patch
SRPM:
http://lspooky.fedorapeople.org/bkchem/0.12.5/2/bkchem-0.12.5-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]