Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476357 --- Comment #3 from Conrad Meyer <konrad@xxxxxxxxxx> 2008-12-18 06:35:46 EDT --- (In reply to comment #2) > > - [ ??? ] MUST: The package must meet the Packaging Guidelines. > > Why -utils subpackage? > > Well, the library can be used without the utilities - therefore the split. The > utilities are end user utilities that use this library to convert icns to png > and vice versa. OK. > > - [ BAD ] MUST: The sources used to build the package must match the > > upstream source, as provided in the spec URL. Reviewers should use > > md5sum for this task. If no upstream URL can be specified for this > > package, please see the Source URL Guidelines for how to deal with this. > > > > md5sum = f6ab74c2cfd4ab5b11d1cb9114743c90 > > > > I can't actually download this from the given URL -- sourceforge gives > > me a bunch of redirects and then a 404. > > I just followed the packaging guideline to provide a source URL that is on > Sourceforge: > https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net > > To check the md5, you can use a mirror. The download.sf.net* urls just redirect to mirrors. The problem is none of the mirrors have the file. > > - [ BAD ] MUST: Packages containing pkgconfig(.pc) files must > > 'Requires: pkgconfig' (for directory ownership and usability). > > I'll fix this. OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review