Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453839 Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orcanbahri@xxxxxxxxx Flag| |fedora-review? --- Comment #9 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-12-18 02:49:36 EDT --- OK, here is the full review. In addition to the above two things: - rpmlint errors can be ignored. * I don't think you need to BR: wxPython-devel . The package builds fine without it. * Source0 link is broken. Does this change frequently? If yes, I guess you should just put the filename, not the full URL (but in this case, make a comment in the SPEC file). * Any reason why you skipped packaging docs/phatch_dev.txt in %doc ? * Please follow the desktop-database and mimeinfo sections (4.6 and 4.7) at http://fedoraproject.org/wiki/Packaging/ScriptletSnippets * The python egg shouldn't be excluded, but it should be built in a proper way. This is a non-setuptools package. So follow: http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review