Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454416 Adam Tkac <atkac@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Adam Tkac <atkac@xxxxxxxxxx> 2008-12-17 08:20:18 EDT --- Sorry for late response. Formal review: source files match upstream: YES package meets naming and versioning guidelines: YES specfile is properly named, is cleanly written and uses macros consistently: YES dist tag is present: YES build root is correct: YES license field matches the actual license: YES latest version is being packaged: YES BuildRequires are proper: YES compiler flags are appropriate: NO %clean is present: YES package builds in mock (Rawhide/x86_64): YES ------- rpmlint is silent: NO: $ rpmlint mingw32-zlib-1.2.3-10.fc11.src.rpm mingw32-zlib.src:46: W: configure-without-libdir-spec - wouldn't be better to add "--libdir=%{_mingw32_libdir}" configure parameter? $ rpmlint mingw32-zlib-1.2.3-10.fc11.noarch.rpm mingw32-zlib.noarch: W: no-documentation mingw32-zlib.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/zlib.h mingw32-zlib.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libz.dll.a mingw32-zlib.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/zconf.h mingw32-zlib.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libz.dll.a mingw32-zlib.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 - OK (there is no reason to separate headers to -devel - noone will use mingw32-zlib-libs package without -devel on Fedora) ------ final provides and requires look sane: YES doesn't own any directories it shouldn't: YES no duplicates in %files: YES file permissions are appropriate: YES code, not content: YES documentation is small, so no -docs subpackage is necessary: YES ---------------------------------------------------------------- Currently I see two problems: - compiler flags are not correct, it seems you have to add "CFLAGS=%{_mingw32_cflags}" parameter to make - static version of library is packaged: $ file /usr/i686-pc-mingw32/sys-root/mingw/lib/libz.dll.a /usr/i686-pc-mingw32/sys-root/mingw/lib/libz.dll.a: current ar archive MinGW packaging guidelines says that static libraries should be packaged in -static subpackage (http://fedoraproject.org/wiki/Packaging/MinGW, "Static libraries" statement). Yes, it is pedantry but guidelines should be honoured. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review