[Bug 476660] Review Request: rubygem-restr - Simple client for RESTful web services

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476660


Jason Tibbitts <tibbs@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |tibbs@xxxxxxxxxxx
               Flag|                            |fedora-review+




--- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx>  2008-12-16 21:50:28 EDT ---
I note the upstream web site indicates 0.5.0 is out, but I can't find the files
anywhere.  That's the only weirdness I see; the package looks fine.

* source files match upstream.  sha256sum:
  db5a48d21f562af94a57bf92e44cf7d570b1f8065f4b8e83a995b796b09711a0  
   restr-0.4.0.gem
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   rubygem(restr) = 0.4.0
   rubygem-restr = 0.4.0-1.fc11
  =
   /usr/bin/env
   ruby(abi) = 1.8
   rubygems

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* rubygem(%{gemname}) provided.
* gems installed properly.
* gems installed to proper directory.
* gems, cache, and specifications files/directories owned properly.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]