Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476483 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-12-16 20:42:23 EDT --- Builds fine; rpmlint says: ghc-paths-prof.x86_64: W: no-documentation which is true, and not a problem. ghc-paths.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.10.1/ghc-paths-0.1.0.5/libHSghc-paths-0.1.0.5.a ghc-paths-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.10.1/ghc-paths-0.1.0.5/libHSghc-paths-0.1.0.5_p.a which are normal for Haskell packages. The only real complaint I have is that the module description doesn't make a whole lot of sense. I guess it must make sense if you understand Haskell (which I don't); that's not really unheard of when it comes to specialized modules for various languages, so I'm not going to worry about it. Maybe you can think of something more sensible. * source files match upstream. sha256sum: ea9e97425894e3dbd7915e00e107e2e7fc07b6e8293fd2dd66a813f0673cba10 ghc-paths-0.1.0.5.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: ghc-paths-0.1.0.5-1.fc11.x86_64.rpm ghc-paths-devel = 0.1.0.5-1.fc11 ghc-paths = 0.1.0.5-1.fc11 ghc-paths(x86-64) = 0.1.0.5-1.fc11 = /bin/sh ghc = 6.10.1 ghc-paths-prof-0.1.0.5-1.fc11.x86_64.rpm ghc-paths-prof = 0.1.0.5-1.fc11 ghc-paths-prof(x86-64) = 0.1.0.5-1.fc11 = ghc-paths = 0.1.0.5-1.fc11 ghc-prof = 6.10.1 * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * scriptlets OK (ghc package registration and documentation indexing) * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review