Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460779 Richard W.M. Jones <rjones@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(rjones@xxxxxxxxxx | |) | --- Comment #7 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2008-12-16 10:28:43 EDT --- (In reply to comment #4) > BAD no shared libraries are added to the regular linker search paths. > BAD no scriptlets present. This is fixed now so that the shared library has an SONAME, and we run ldconfig in the %post/%postun scriptlets. > - use --keepdate when running dos2unix to preserve the timestamps for the files Done. > - shared library is added, but ldconfig scriptlets are missing Done. > - rpmlint complains rpmlint now says: nekovm.src:114: E: hardcoded-library-path in %{_prefix}/lib nekovm.src:121: E: hardcoded-library-path in %{_prefix}/lib nekovm.src:122: E: hardcoded-library-path in %{_prefix}/lib/* nekovm.src:123: E: hardcoded-library-path in %{_prefix}/lib 3 packages and 0 specfiles checked; 4 errors, 0 warnings. But in this case it's just complaining about my install script which is moving the files FROM %{_prefix}/lib to %{_libdir}. I think this is rpmlint getting it wrong. > - I think these will create a multilib issue together with shared libneko.so > in the main package Fixed so now it uses %{_libdir} always. > - what is the purpose of the *.ndll? runtime libs for nekovm based apps? These are some type of runtime shared library containing neko VM code. > nekovm.x86_64: W: no-soname /usr/lib64/libneko.so > - result of not-so-right linking command This is now fixed. > I think you need to split the package to > main - %{_bindir} + /usr/lib/neko > libs - %{_libdir} > devel - %{_includedir} I don't think this split will work. The reason is that the main package will always require the -libs package, because it always needs (at least) std.ndll. This is the updated package: Spec URL: http://www.annexia.org/tmp/ocaml/nekovm.spec SRPM URL: http://www.annexia.org/tmp/ocaml/nekovm-1.8.0-2.fc10.src.rpm * Tue Dec 16 2008 Richard W.M. Jones <rjones@xxxxxxxxxx> - 1.8.0-2 - New upstream release 1.8.0. - Use dos2unix --keepdate. - Use scriptlets to run ldconfig. - Use _libdir instead of _prefix/lib, and modify so it searches /usr/lib64 as well as /usr/lib. - Set the soname correctly and include libneko.so.1. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review