Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226417 --- Comment #5 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-12-15 11:03:02 EDT --- Thanks for the update. Everything looks fine. I just have two more comments. > > * The BR perl-XML-Parser >= 2.31-16 is not used at all and can be removed. Am I > > wrong? > > Needed for intltool, I change it to "perl(XML::Parser)" though. > Ah, I noticed that now. Just a side-note: BR'ing "intltool" will then pull up "perl(XML::Parser)", so still, explicitly BR'ing "perl(XML::Parser)" is not required. But if you think this dependency might change in the future, I'm OK with leaving it as it is. > > * The files ChangeLog, HACKING and most importantly COPYING need to be listed > > under %doc. > > Added HACKING and COPYING, not ChangeLog, as it replicates data from NEWS > whilst being much bigger. > Does NEWS contain all the relevant information from ChangeLog (both from a user's and a developer's point of view)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review