Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226417 Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bnocera@xxxxxxxxxx, | |orcanbahri@xxxxxxxxx --- Comment #1 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-12-14 23:12:45 EDT --- I reviewed this package. It surely needs some work: * Can bug #459365 be closed now? * gawk is among the default package set and hence doesn't need to be BR'd. * The BR perl-XML-Parser >= 2.31-16 is not used at all and can be removed. Am I wrong? * rpmlint says: shared-mime-info.x86_64: W: devel-file-in-non-devel-package /usr/share/pkgconfig/shared-mime-info.pc Is there a valid reason why this file is not in a -devel package? Also, from the guidelines: "Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability)." shared-mime-info.x86_64: E: explicit-lib-dependency glib2 shared-mime-info.x86_64: E: explicit-lib-dependency libxml2 I believe that these explicit R's can be dropped since rpmbuild itself picks up these dependencies. * Group tag is "System Environment/Libraries" but I don't see a library in this package. * What is wrong with the locale files in the tarball? (A more detailed explanation as a comment within the SPEC file please.) Also, assuming you have a legitimate reason to remove these files, why are you BR'ing gettext? * The files ChangeLog, HACKING and most importantly COPYING need to be listed under %doc. * Macros should be used consistently. If you want to use %{__rm} notation, use macros for the other commands as well (%{__cat}, %{__make}, etc.). OR do it the other way around. But please stay consistent. * Buildroot should be one of these: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %{_tmppath}/%{name}-%{version}-%{release}-root * According to the COPYING and test-tree-magic.c files, the license tag should be GPLv2+ * The main source file (Source0) should be given in full URL. * Parallel make must be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment. * About the defaults.list: Can't we provide a separate list for KDE users? This may need some hacking on the source code. * See http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo for correct usage of the snippet. It's interesting to see that the very package that this guideline is based on doesn't obey the guideline itself (at least, partially). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review