Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476443 Brennan Ashton <bashton@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |bashton@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |bashton@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Brennan Ashton <bashton@xxxxxxxxxxxxxxxxx> 2008-12-14 15:38:41 EDT --- [x]source files match upstream: 95aab98d316ce5289e80840301da7dea8f7fffc4931506afaf092aec1c063fe3 Hardware-Vhdl-Parser-0.12.tar.gz [x]package meets naming and versioning guidelines. [x]specfile is properly named, is cleanly written and uses macros consistently. [x]dist tag is present. [x]build root is correct. [x]license field matches the actual license. [x]license is open source-compatible. [x]latest version is being packaged. [x]BuildRequires are proper. [x]compiler flags are appropriate. [x]%clean is present. [x]package builds in mock. package installs properly. NO, you need to add find . -type f | xargs %{__perl} -pi -e 's|#! /bin/perl|#! /usr/bin/perl|' to your spec file, the script are looking for perl in /bin/perl and it will not install because rpm want a package that provides /bin/perl. When I added this to the spec file after %setup it is happy. [x]rpmlint is silent. 2 packages and 1 specfiles checked; 0 errors, 0 warnings. [x]%check is present and all tests pass: Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.nopDDm + umask 022 + cd /home/makerpm/rpmbuild/BUILD + cd Hardware-Vhdl-Parser-0.12 + unset DISPLAY + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl 1..2 ok 1 Test 2 OK [x]no shared libraries are added to the regular linker search paths. [x]no duplicates in %files. [x]file permissions are appropriate. [x]no scriptlets present. [x]documentation is small, so no -docs subpackage is necessary. [x]%docs are not necessary for the proper functioning of the package. Once you have made that change I will approve the package. I made it locally and it passes tests on a vhd file I made. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review