Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474768 --- Comment #5 from Thorsten Leemhuis <fedora@xxxxxxxxxxxxx> 2008-12-13 09:27:31 EDT --- (In reply to comment #4) * >> - summary should not start with "A" or "An" > fixed Really? I still see "Summary: A enhanced backup plugin for J-Pilot" ;-) * >> - Remove the *.la files. They should not be included. > as you can see in the -4 spec, I manually remove it but have provisions in > place to build a -static subpackage. I think just removing is better in this > case but would like comments. Removing definitely is better. Static subpackages are hightly discouraged in Fedora; see packaging guidelines for details. (quoting from the spec or rpmlint) * > License: GPLv2 Looks more like GPLv2+ to me (or did I miss something?). * > Requires: gdbm Why is that needed? RPM automatically adds a requires for "libgdbm.so.2()", hence please remove it if there there are no good reason for it. * >$ rpmlint rpmbuild/RPMS/x86_64/jpilot-backup-* jpilot-backup-0.53-4.fc10.src.rpm >jpilot-backup.src: W: strange-permission jpilot-backup.spec 0600 >3 packages and 0 specfiles checked; 0 errors, 1 warnings. Please fix * looks good apart from the above -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review